Skip to content

Fix Firefox quick bar issue by allowing Ctrl+P to toggle modes#7413

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
donkawechico:ctrl_p_toggles_mode
Oct 21, 2020
Merged

Fix Firefox quick bar issue by allowing Ctrl+P to toggle modes#7413
bramkragten merged 2 commits intohome-assistant:devfrom
donkawechico:ctrl_p_toggles_mode

Conversation

@donkawechico
Copy link
Contributor

@donkawechico donkawechico commented Oct 21, 2020

Proposed change

If quick bar is already launched, hitting the launch shortcut again will switch between modes.

This is both a fast, natural way to switch between modes, and also would (mostly) resolve the bug where Firefox will never allow Ctrl+Shift+P: #7410

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@donkawechico donkawechico changed the title Hitting Ctrl+P when quick bar already open toggles mode Fix Firefox quick bar issue by allowing Ctrl+P to toggle modes Oct 21, 2020
@bramkragten bramkragten merged commit bcf405b into home-assistant:dev Oct 21, 2020
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick Bar: Shortcut for command input not working in Firefox

3 participants