Use attribute picker for sec. info in weather card editor#7335
Use attribute picker for sec. info in weather card editor#7335bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
| .value=${this._value} | ||
| .allowCustomValue=${this.allowCustomValue} | ||
| .renderer=${rowRenderer} | ||
| attr-for-value="bind-value" |
There was a problem hiding this comment.
Without that line, the value was not shown in the input until you clicked into the field. All existing usages of <ha-entity-attribute-picker> in the code base set the attribute allow-custom-value. With that set, it works fine, but without this additional option was required.
|
The 2 issues in your description are not specific for this PR right? They are general issues? Could you create an issue for them? |
|
Check #7343 for fixing the first. The second could be fixed with some padding, but please check the material guidelines first. |
Yes, generic. Is the rest of this PR good from your point of view? For the other topics I will have a look if I can fix them based on the PR and hint you mentioned. If not, I will create the separate issues. |
Breaking change
Proposed change
Use attribute picker in the weather card editor.
There are a few somewhat related challenges:
Due to the flex shrinking, the "suffix" slot of the used
<paper-input>gets too narrow and stacks the clear and menu icons. I wasn't able to get that sorted out via CSS so far with the mixins (--paper-input-suffix). I only could verify via the browser dev tools, that withflex-shrink: 0applied to the "suffix"<span>the issue disappears.The
<ha-switch>is too far to the left as you can see by the shown helper lines. I am unsure whether just moving that instance a bit to the right is the correct approach. I haven't found other places with the same issue, but then again all other usages of<ha-switch>that I found use the some code.@bramkragten Can you provide some guidance / ideas here?
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: