Modified icons of binary sensors: gas, problem, safety, smoke#7403
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Oct 20, 2020
Merged
Modified icons of binary sensors: gas, problem, safety, smoke#7403bramkragten merged 1 commit intohome-assistant:devfrom
bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
bramkragten
approved these changes
Oct 20, 2020
Merged
|
Sorry if it's not the proper place, but this brings a small issue of icon usage consistency. eg: Here, a checkmark both means "Ok, no action" (Meteo Alarm) and "Attention, action required" (Updater). A bit confusing, so maybe adjusting the "default" binary sensor icons might be desirable. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Breaking change
Proposed change
Modified icons of binary sensors: gas, problem, safety, smoke
Icons are consistent (both icons are circles now) and circles are probably better because shield is often used for alarm.
We may also use
mdi-check-circle-outlinefor "off" state to make better visual difference between "on" and "off" states.Updated version of #6824 because there's no response.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: