Skip to content

Modified icons of binary sensors: gas, problem, safety, smoke#7403

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
kukulich:binary-sensor-icons
Oct 20, 2020
Merged

Modified icons of binary sensors: gas, problem, safety, smoke#7403
bramkragten merged 1 commit intohome-assistant:devfrom
kukulich:binary-sensor-icons

Conversation

@kukulich
Copy link
Contributor

Breaking change

Proposed change

Modified icons of binary sensors: gas, problem, safety, smoke
Icons are consistent (both icons are circles now) and circles are probably better because shield is often used for alarm.

We may also use mdi-check-circle-outline for "off" state to make better visual difference between "on" and "off" states.

Updated version of #6824 because there's no response.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 5065901 into home-assistant:dev Oct 20, 2020
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@koying
Copy link

koying commented Nov 3, 2020

Sorry if it's not the proper place, but this brings a small issue of icon usage consistency.
I don't have any issue with this change as such, but now, the "checkmark" icon is used both for "off" state for gas, problem, safety, smoke and "on" state for unknown device classes like the updater.

eg:

image

Here, a checkmark both means "Ok, no action" (Meteo Alarm) and "Attention, action required" (Updater).

A bit confusing, so maybe adjusting the "default" binary sensor icons might be desirable.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants