Merged
Conversation
Contributor
Author
|
The code formatter really did a number on the diff for this one, but with whitespace changes hidden it looks all right. |
thomasloven
commented
Oct 9, 2020
Comment on lines
+605
to
+609
| private _preprocessYaml() { | ||
| const cleanConfig = deepClone(this._config); | ||
| delete cleanConfig.id; | ||
| return cleanConfig; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
For explanation of why this is a thing: We do not want the user to mess with the id property, and we don't want it to be copied and pasted either.
I plan more uses for this function. That's why it's present in the script editor even though it has no id.
Contributor
Author
There was a problem hiding this comment.
Actually, come to think of it those uses won't apply to scripts anyway. But maybe it should be left in there for consistency?
Edit: Actually actually, they might.
Contributor
There was a problem hiding this comment.
Yes I need this for the grid layout as well. I just didn't know the best way to do it. Thanks! :)
bramkragten
reviewed
Oct 9, 2020
bramkragten
reviewed
Oct 9, 2020
bramkragten
reviewed
Oct 9, 2020
zsarnett
reviewed
Oct 10, 2020
zsarnett
reviewed
Oct 10, 2020
zsarnett
reviewed
Oct 10, 2020
zsarnett
reviewed
Oct 10, 2020
zsarnett
reviewed
Oct 10, 2020
zsarnett
reviewed
Oct 10, 2020
zsarnett
reviewed
Oct 10, 2020
zsarnett
reviewed
Oct 10, 2020
zsarnett
reviewed
Oct 10, 2020
zsarnett
reviewed
Oct 10, 2020
zsarnett
reviewed
Oct 10, 2020
zsarnett
reviewed
Oct 10, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This replaces #6986
Also fixes a translation error in the script editor menu.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: