Add button that dismisses all notifications#7223
Merged
zsarnett merged 3 commits intohome-assistant:devfrom Oct 15, 2020
Merged
Add button that dismisses all notifications#7223zsarnett merged 3 commits intohome-assistant:devfrom
zsarnett merged 3 commits intohome-assistant:devfrom
Conversation
Contributor
|
Hi @mattmattmatt, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
zsarnett
reviewed
Oct 5, 2020
9 tasks
bramkragten
reviewed
Oct 5, 2020
bramkragten
approved these changes
Oct 5, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Resolves this feature request that proposes a Dismiss All button in the notification list.
The new functionality adds a button at the bottom of the notification list that is only visible when there are 2 or more notifications. When pressed, a loop calls the
persistent_notification.dismissservice on each notification, after which the notification drawer closes.Type of change
Example configuration
Additional information
This is my first time working in HA Frontend, and also my first time working with Polymer/Lit. Please let me know of any best practices I may have missed and I'll be happy to amend the PR.
Checklist
If user exposed functionality or configuration variables are added/changed: