Skip to content

Add button that dismisses all notifications#7223

Merged
zsarnett merged 3 commits intohome-assistant:devfrom
mattmattmatt:dismiss-all-notifications
Oct 15, 2020
Merged

Add button that dismisses all notifications#7223
zsarnett merged 3 commits intohome-assistant:devfrom
mattmattmatt:dismiss-all-notifications

Conversation

@mattmattmatt
Copy link
Contributor

Proposed change

Resolves this feature request that proposes a Dismiss All button in the notification list.

The new functionality adds a button at the bottom of the notification list that is only visible when there are 2 or more notifications. When pressed, a loop calls the persistent_notification.dismiss service on each notification, after which the notification drawer closes.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

This is my first time working in HA Frontend, and also my first time working with Polymer/Lit. Please let me know of any best practices I may have missed and I'll be happy to amend the PR.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@homeassistant
Copy link
Contributor

Hi @mattmattmatt,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@zsarnett zsarnett merged commit 5b1a2d1 into home-assistant:dev Oct 15, 2020
@mattmattmatt mattmattmatt deleted the dismiss-all-notifications branch October 15, 2020 21:23
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dismiss All button in persistent notification sidebar

4 participants