Skip to content

Add keyboard shortcut to save automation/scene/script#7207

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
gilsonmandalogo:dev
Oct 8, 2020
Merged

Add keyboard shortcut to save automation/scene/script#7207
bramkragten merged 1 commit intohome-assistant:devfrom
gilsonmandalogo:dev

Conversation

@gilsonmandalogo
Copy link
Contributor

Proposed change

Add CMD+S or CTRL+S keyboard shortcut to save automation/scene/script.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

No configuration needed.

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@iantrich
Copy link
Member

iantrich commented Oct 3, 2020

🎉🎉🎉🎉

@bramkragten
Copy link
Member

Can we make this a class mixing, that will call a function of the class when ctrl+s is called?

@gilsonmandalogo
Copy link
Contributor Author

@bramkragten Thanks for your suggestions. This is my first time with LitElement, but I'll look at documentation to do this.

Copy link
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 great!

@bramkragten bramkragten merged commit 0f0a3fd into home-assistant:dev Oct 8, 2020
@donkawechico
Copy link
Contributor

donkawechico commented Oct 9, 2020

First of all, this is awesome.

Second of all, and this is an admittedly unlikely scenario, but now that Quick Bar (with its two hotkeys) is a thing, we might want to think of ways to avoid collisions.

Some kind of shortcut registry, or at least unifying them all under a common mixin where a dev is likely to see what's already taken.

Also, might consider checking for mac OS to avoid having duplicate hotkeys (see: #7293). Standardizing our shortcuts would help this as well.

Update: Took a stab at this consolidation over here: #7314

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants