Detect Lovelace resource type based on file extension#7354
Merged
bramkragten merged 6 commits intohome-assistant:devfrom Oct 19, 2020
Merged
Detect Lovelace resource type based on file extension#7354bramkragten merged 6 commits intohome-assistant:devfrom
bramkragten merged 6 commits intohome-assistant:devfrom
Conversation
zsarnett
reviewed
Oct 15, 2020
src/panels/config/lovelace/resources/dialog-lovelace-resource-detail.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Oct 15, 2020
src/panels/config/lovelace/resources/dialog-lovelace-resource-detail.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Oct 16, 2020
src/panels/config/lovelace/resources/dialog-lovelace-resource-detail.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Oct 16, 2020
src/panels/config/lovelace/resources/dialog-lovelace-resource-detail.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Oct 17, 2020
bramkragten
reviewed
Oct 19, 2020
bramkragten
reviewed
Oct 19, 2020
src/panels/config/lovelace/resources/dialog-lovelace-resource-detail.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Oct 19, 2020
src/panels/config/lovelace/resources/dialog-lovelace-resource-detail.ts
Outdated
Show resolved
Hide resolved
Member
Author
bramkragten
reviewed
Oct 19, 2020
src/panels/config/lovelace/resources/dialog-lovelace-resource-detail.ts
Outdated
Show resolved
Hide resolved
bramkragten
approved these changes
Oct 19, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Breaking change
Proposed change
Automatically detect the resource type based on the extension. Initially we now start with an empty dropdown. As long as it is empty and as soon as an URL is inserted we will check for extensions "js" and "css" to automatically determine the type.
One the dropdown has a value we no longer update it, even if the URL is changed, but the user can still manually change/override the selection.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: