Conversation
bramkragten
force-pushed
the
bump-typescript-babel
branch
from
ec09416 to
7fc7f6d
Compare
balloob
reviewed
Oct 7, 2020
|
|
||
| export const getOptimisticCollection = <StateType>( | ||
| saveCollection: (conn: Connection, data: StateType) => Promise<unknown>, | ||
| saveCollection: (conn2: Connection, data: StateType) => Promise<unknown>, |
Member
There was a problem hiding this comment.
I don't understand this change, the variable name is not shadowing anything ?
Member
Author
There was a problem hiding this comment.
True, it is not needed for this one because it is above conn, but feels weird not do this one and do the others...
Member
There was a problem hiding this comment.
I don't really care. conn2 is just a little weird, maybe conn_ would be better.
balloob
approved these changes
Oct 7, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Bump typescript (4) and babel
https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/
https://github.com/babel/babel/releases
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: