Skip to content

Add warning to badge preview in "Panel Mode"#7331

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:badges-panel-mode
Oct 13, 2020
Merged

Add warning to badge preview in "Panel Mode"#7331
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:badges-panel-mode

Conversation

@spacegaier
Copy link
Member

@spacegaier spacegaier commented Oct 13, 2020

Breaking change

Proposed change

Mention badges in the panel mode info text:
image

Add warning to badge preview if in panel mode:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

I think the warning should be at the top or the bottom, not in the middle?

@spacegaier
Copy link
Member Author

@bramkragten I moved it to the top now (to mirror where the warning is for the cards).

@bramkragten bramkragten merged commit 0d741b6 into home-assistant:dev Oct 13, 2020
@spacegaier spacegaier deleted the badges-panel-mode branch October 13, 2020 17:03
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add text about Panel Mode not rendering badges

3 participants