Skip to content

Fix navigation links for "script/edit"#7363

Merged
zsarnett merged 2 commits intohome-assistant:devfrom
spacegaier:fix-script-edit-link
Oct 17, 2020
Merged

Fix navigation links for "script/edit"#7363
zsarnett merged 2 commits intohome-assistant:devfrom
spacegaier:fix-script-edit-link

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Navigation from the device and the area config page is broken, since the coding attempts to read an attribute "id" which however does not exist for scripts. Instead the "entity_id" needs to be used.

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett merged commit e603893 into home-assistant:dev Oct 17, 2020
@spacegaier spacegaier deleted the fix-script-edit-link branch October 17, 2020 22:43
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants