Fix: Quick Bar not launching on windows#7293
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Oct 13, 2020
Merged
Conversation
donkawechico
force-pushed
the
quick_bar_windows_fix
branch
from
2fdccc9 to
2652451
Compare
donkawechico
changed the title
donkawechico
force-pushed
the
quick_bar_windows_fix
branch
from
2652451 to
30300a0
Compare
donkawechico
commented
Oct 9, 2020
9 tasks
zsarnett
approved these changes
Oct 10, 2020
Contributor
zsarnett
left a comment
zsarnett
left a comment
There was a problem hiding this comment.
Confirmed working on Windows Chrome now
bramkragten
reviewed
Oct 12, 2020
donkawechico
force-pushed
the
quick_bar_windows_fix
branch
from
30300a0 to
b03a920
Compare
bramkragten
reviewed
Oct 12, 2020
donkawechico
force-pushed
the
quick_bar_windows_fix
branch
from
b03a920 to
d9ea7cc
Compare
zsarnett
reviewed
Oct 13, 2020
| } | ||
|
|
||
| private isOSCtrlKey(e: KeyboardEvent) { | ||
| return isMacOS ? e.metaKey : e.ctrlKey; |
Contributor
There was a problem hiding this comment.
Lets just add this to the if?
Contributor
Author
There was a problem hiding this comment.
I'm personally a fan of using tiny, well-named functions that explain, without code comments, why something's being done.
But I'm fine with whatever here.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes bug with Quick Bar on Windows.
Code was only looking for
e.metaKeywhich is true for mac OS's "⌘" but not Windows's Control Key.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: