Skip to content

Do not show weather forecast in generated UI#7251

Merged
bramkragten merged 1 commit intodevfrom
generated-weather
Oct 8, 2020
Merged

Do not show weather forecast in generated UI#7251
bramkragten merged 1 commit intodevfrom
generated-weather

Conversation

@balloob
Copy link
Member

@balloob balloob commented Oct 7, 2020

Breaking change

Proposed change

I think that the weather card with forecast is too big and takes up too much space. The generated UI should be making it easy to control your devices. Weather can be a lot smaller.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob
Copy link
Member Author

balloob commented Oct 7, 2020

Btw, it looks like not all icons that we use are vertically centered

image

@bramkragten bramkragten merged commit 113718c into dev Oct 8, 2020
@bramkragten bramkragten deleted the generated-weather branch October 8, 2020 11:29
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants