Harmonize the font sizes on area and device page#7357
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Oct 17, 2020
Merged
Harmonize the font sizes on area and device page#7357bramkragten merged 1 commit intohome-assistant:devfrom
bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
zsarnett
reviewed
Oct 16, 2020
Contributor
zsarnett
left a comment
There was a problem hiding this comment.
hmm I am not sure if we should use paper sizes. Can we just use a px?
Member
Author
|
@zsarnett I would be fine either way. In many places int he frontend we do already set the font-size fix to 14px, but on the other hand we do have the same paper size used in our frontend/src/resources/styles.ts Lines 92 to 99 in 7251e80 Should we wait for @bramkragten to chime in as well? |
bramkragten
approved these changes
Oct 17, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
If there are no automation, scenes or scripts for a device, the corresponding note text uses a too big font size, not matching the rest of the visual feel. To be consistent, I applied the same font size, to when there are created elements in those boxes as well.
Same applies to the area display.
Note: Before the change, the paper font size for a sub header was applied.
Before

After

Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: