Skip to content

Fix issue with enter key not executing selected item in quick bar list#7283

Merged
bramkragten merged 3 commits intohome-assistant:devfrom
donkawechico:quick_bar_fix_enter_key
Oct 13, 2020
Merged

Fix issue with enter key not executing selected item in quick bar list#7283
bramkragten merged 3 commits intohome-assistant:devfrom
donkawechico:quick_bar_fix_enter_key

Conversation

@donkawechico
Copy link
Contributor

Proposed change

Fixes bug in new quick bar where enter key will not execute the currently-selected list item (tabbing into it, for example).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@donkawechico donkawechico force-pushed the quick_bar_fix_enter_key branch 2 times, most recently from 1dffadb to d0b1e1c Compare October 9, 2020 18:48
@donkawechico donkawechico marked this pull request as ready for review October 9, 2020 18:53
@donkawechico donkawechico force-pushed the quick_bar_fix_enter_key branch from db4c467 to 3e4912e Compare October 13, 2020 00:52
@donkawechico
Copy link
Contributor Author

Resolved merge conflicts

@donkawechico donkawechico force-pushed the quick_bar_fix_enter_key branch from 3e4912e to a759fd2 Compare October 13, 2020 00:57
@bramkragten bramkragten merged commit 5cddb48 into home-assistant:dev Oct 13, 2020
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants