Skip to content

Styling fixes for hui-masonry-view#7226

Merged
zsarnett merged 2 commits intohome-assistant:devfrom
maykar:dev
Oct 4, 2020
Merged

Styling fixes for hui-masonry-view#7226
zsarnett merged 2 commits intohome-assistant:devfrom
maykar:dev

Conversation

@maykar
Copy link
Contributor

@maykar maykar commented Oct 4, 2020

Proposed change

Adds some styling changes to hui-masonry-view. This returns the amount of padding between the header and view/cards that existed before 0.116 and also fixes empty space that appears when using badges that was introduced with the same changes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

views:
  - icon: 'mdi:bomb'
    background: dimgrey
    cards:
      - type: gauge
        entity: sensor.connected_clients
        min: 0
        max: 100
  - icon: 'mdi:triforce'
    background: dimgrey
    badges:
      - device_tracker.demo_paulus
    cards:
      - type: gauge
        entity: sensor.connected_clients
        min: 0
        max: 100

Additional information

View with spacing between header and cards before:

drawing

View with spacing between header and cards after:

drawing

View with badges before:

drawing

View with badges after:

drawing

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@homeassistant
Copy link
Contributor

Hi @maykar,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@balloob balloob requested a review from zsarnett October 4, 2020 19:19
Copy link
Contributor

@zsarnett zsarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Great! Thanks!

@zsarnett zsarnett added this to the 0.116.0 milestone Oct 4, 2020
@zsarnett zsarnett merged commit 9873459 into home-assistant:dev Oct 4, 2020
bramkragten pushed a commit that referenced this pull request Oct 5, 2020
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants