Merged
Conversation
balloob
approved these changes
Oct 16, 2020
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Can we add a comment why it exists?
zsarnett
approved these changes
Oct 16, 2020
nick2525
reviewed
Oct 16, 2020
nick2525
approved these changes
Oct 16, 2020
balloob
reviewed
Oct 16, 2020
| @property({ type: Boolean, attribute: "allow-exoplayer" }) | ||
| public allowExoPlayer = false; | ||
|
|
||
| @query("video", true) private _videoEl!: HTMLVideoElement; |
Member
|
If this fixes home-assistant/android#979 maybe it should be included on the current version as a point release? It is draining battery and eating a lot of traffic. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Don't cache video el, as it gets recreated
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: