Skip to content

Remove query caching to get YAML editor toggle working again#7365

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:fix-yaml-editor-toggle
Oct 16, 2020
Merged

Remove query caching to get YAML editor toggle working again#7365
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:fix-yaml-editor-toggle

Conversation

@spacegaier
Copy link
Member

Breaking change

Proposed change

This PR broke the toggle: #7245

When the click handler is called _cardEditorEl is now always null and therefore nothing happens. Without the caching flag, everything works fine.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 1d316c3 into home-assistant:dev Oct 16, 2020
@spacegaier spacegaier deleted the fix-yaml-editor-toggle branch October 16, 2020 21:28
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants