Skip to content

Fix icon for unavailable buttons#7416

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
iantrich:unavailable-buttons
Oct 21, 2020
Merged

Fix icon for unavailable buttons#7416
bramkragten merged 2 commits intohome-assistant:devfrom
iantrich:unavailable-buttons

Conversation

@iantrich
Copy link
Member

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 7e2dc04 into home-assistant:dev Oct 21, 2020
if (!stateObj || !this._showIcon) {
if (!stateObj) {
return html`<div class="missing">
<ha-icon icon="hass:alert"></ha-icon>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use ha-svg-icon here

@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button disappears in buttons row when an entity is unavailable

4 participants