Skip to content

Supervisor disk usage more info#7247

Merged
ludeeus merged 26 commits intohome-assistant:devfrom
maykar:disk-usage-title-info
Oct 9, 2020
Merged

Supervisor disk usage more info#7247
ludeeus merged 26 commits intohome-assistant:devfrom
maykar:disk-usage-title-info

Conversation

@maykar
Copy link
Contributor

@maykar maykar commented Oct 6, 2020 •
edited
Loading

Proposed change

Adds more info about used and available disk space on hover of disk usage bar in supervisor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

ludeeus
ludeeus requested changes Oct 7, 2020
View reviewed changes
@maykar maykar requested a review from ludeeus October 7, 2020 15:30
ludeeus
ludeeus requested changes Oct 8, 2020
View reviewed changes
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supervisor RAM is missing tip

@maykar maykar marked this pull request as ready for review October 8, 2020 14:10
ludeeus
ludeeus reviewed Oct 8, 2020
View reviewed changes
@maykar @ludeeus
Remove unneeded undefined fallback
7ab5640 
Co-authored-by: Joakim Sørensen <ludeeus@gmail.com>
@maykar maykar requested a review from ludeeus October 8, 2020 14:35
@ludeeus ludeeus added the Supervisor Related to the supervisor panel label Oct 8, 2020
ludeeus
ludeeus approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bramkragten
bramkragten reviewed Oct 8, 2020
View reviewed changes
@ludeeus ludeeus merged commit 892843b into home-assistant:dev Oct 9, 2020
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bramkragten bramkragten bramkragten left review comments

@ludeeus ludeeus ludeeus approved these changes

Assignees

No one assigned

Labels

cla-signed hacktoberfest Supervisor Related to the supervisor panel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FR: Add absolute total/available space to the System Metrics panel in Supervisor->System

4 participants

@maykar @bramkragten @ludeeus @homeassistant