Skip to content

Ensure ha-dialog uses correct <a> color#7255

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:ha-dialog-a
Oct 9, 2020
Merged

Ensure ha-dialog uses correct <a> color#7255
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:ha-dialog-a

Conversation

@spacegaier
Copy link
Member

Breaking change

Proposed change

Previously hyperlinks in a ha-dialog were not styled properly and therefore used the browsers default coloring (dark blue in my case). This e.g. occurred in the entity persistent_notification.python_version that appears if python version 3.7 is used.

Now, correctly the primary theme color is used, same as for all other links.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@SeanPM5
Copy link
Contributor

SeanPM5 commented Oct 7, 2020

This fixes #7211

@zsarnett zsarnett linked an issue Oct 7, 2020 that may be closed by this pull request
3 tasks
@spacegaier spacegaier requested a review from bramkragten October 9, 2020 06:58
@bramkragten bramkragten merged commit 4773c39 into home-assistant:dev Oct 9, 2020
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@spacegaier spacegaier deleted the ha-dialog-a branch October 22, 2020 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unique ID docs link in more info dialog lacks styling (0.116b1)

4 participants