add help button to tags config panel#7278
Merged
bramkragten merged 2 commits intohome-assistant:devfrom Oct 17, 2020
Merged
Conversation
zsarnett
reviewed
Oct 10, 2020
| hasFab | ||
| > | ||
| <mwc-icon-button slot="toolbar-icon" @click=${this._showHelp}> | ||
| <ha-svg-icon .path=${mdiHelpCircle}></ha-svg-icon> |
Contributor
Author
There was a problem hiding this comment.
As far as I can tell all the necessary imports are there. I added mwc-icon-button, but it doesn't look like ha-svg-icon import is necessary for some reason. I'm not super familiar with this system yet though
Member
There was a problem hiding this comment.
it is needed, but probably already is imported by a parent. You should add it though if the order ever changes it breaks.
zsarnett
approved these changes
Oct 10, 2020
bramkragten
reviewed
Oct 12, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Contributor
|
RIP. ha-svg-icon was never imported |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Added help button + dialog to tags config panel
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: