Fix alignment / padding of ha-switch#7349
Merged
bramkragten merged 2 commits intohome-assistant:devfrom Oct 19, 2020
Merged
Conversation
zsarnett
approved these changes
Oct 15, 2020
Member
|
So officially we should not add padding, but I also don't see our use-case in the material specs. We should make sure the switch lines with the rest of the content, don't stick to the 4px rules of material here. |
Member
Author
bramkragten
approved these changes
Oct 17, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Breaking change
Proposed change
Previously the
<ha-switch>was not properly aligned, see the before/after screenshots. I added 8px of padding, since the material guide says increments of 4px (source), although here 6px might suffice.There is one visual difference I can spot: The label next to the switch is now a bit farther away. That is because the following selector adds a 4px padding on its own. In other frontend areas where a
<ha-switch>is used this does not come into play, since there (e.g. enable buttons of automation or the entity enable button) they are not used in combination with a<ha-formfield>.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: