Skip to content

Update compatibility and fix polyfills for ES5#7298

Merged
bramkragten merged 4 commits intodevfrom
update-compat
Oct 12, 2020
Merged

Update compatibility and fix polyfills for ES5#7298
bramkragten merged 4 commits intodevfrom
update-compat

Conversation

@balloob
Copy link
Member

@balloob balloob commented Oct 10, 2020

Breaking change

Proposed change

Not all things are transpilable for ES5 (rewritten in old syntax). Some things need to be polyfilled (added via functions). The first thing happens automatically, the second doesn't.

It looks like our ES5 build was broken because of the use of Object.entries.

I haven't checked what other methods are used that we don't catch yet. So to make sure we always fix them all, we just will include core-js into compatibility.ts. That will make sure it is loaded correctly without requiring us to check all code.

Then I updated babel-preset-env to limit the import scope of core-js to only include the imports that are needed.

Fixes #5376

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob changed the title Update compatibility Update compatibility and fix polyfills for ES5 Oct 10, 2020
@bramkragten bramkragten merged commit d3ad56a into dev Oct 12, 2020
@bramkragten bramkragten deleted the update-compat branch October 12, 2020 08:48
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IOS 9.3.5 - I can't log in to my Home Assistant. Stuck on initializing

3 participants