Update compatibility and fix polyfills for ES5#7298
Merged
bramkragten merged 4 commits intodevfrom Oct 12, 2020
Merged
Conversation
73473b0 to
dd70713
Compare
bramkragten
approved these changes
Oct 12, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Not all things are transpilable for ES5 (rewritten in old syntax). Some things need to be polyfilled (added via functions). The first thing happens automatically, the second doesn't.
It looks like our ES5 build was broken because of the use of Object.entries.
I haven't checked what other methods are used that we don't catch yet. So to make sure we always fix them all, we just will include
core-jsintocompatibility.ts. That will make sure it is loaded correctly without requiring us to check all code.Then I updated
babel-preset-envto limit the import scope ofcore-jsto only include the imports that are needed.Fixes #5376
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: