Skip to content

Use client_id if no client_name in delete dialog#7228

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
maykar:patch-1
Oct 5, 2020
Merged

Use client_id if no client_name in delete dialog#7228
bramkragten merged 1 commit intohome-assistant:devfrom
maykar:patch-1

Conversation

@maykar
Copy link
Contributor

@maykar maykar commented Oct 5, 2020

Proposed change

When deleting a refresh token the dialog shows an empty name since it's searching for token.client_name, but only long lived tokens have that attribute. This will use token.client_id in those cases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Before:
drawing

After:
drawing

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 05630c9 into home-assistant:dev Oct 5, 2020
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleting refresh token doesn't show token name when it wants to

4 participants