Use client_id if no client_name in delete dialog#7228
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Oct 5, 2020
maykar:patch-1
Merged
Use client_id if no client_name in delete dialog#7228bramkragten merged 1 commit intohome-assistant:devfrom maykar:patch-1
bramkragten merged 1 commit intohome-assistant:devfrom
maykar:patch-1
Conversation
zsarnett
approved these changes
Oct 5, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
When deleting a refresh token the dialog shows an empty name since it's searching for
token.client_name, but only long lived tokens have that attribute. This will use token.client_id in those cases.Type of change
Example configuration
Additional information
Before:

After:

Checklist
If user exposed functionality or configuration variables are added/changed: