Add release notes for 0.290#23936
Conversation
jaystarshot
requested review from
a team,
elharo and
steveburnett
as code owners
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
c44a81e to
1286905
Compare
There was a problem hiding this comment.
I considered and reviewed only the Extracted Release Notes. I did not examine any of the PRs in the Missing Release Notes section of this doc PR to consider if they need new release note entries written for them and added to the doc in this PR.
-
Edited punctuation throughout so that the text of a release note entry ends with a period (.), followed by the PR link - which is not followed by a period for consistency with the previous recent release notes.
-
Other minor edits, capitalizing Presto, Iceberg, Parquet, and the like.
-
Please note the comments where I ask for a review of my suggested changes.
-
Please review these release notes for the headings following the sequence in the Order of sections of the Release Notes Guidelines, and that the entries within each heading follow the Order of changes, especially after my comments and edits are applied.
| ______________________________________ | ||
| * Add ``native_max_local_exchange_partition_count session`` property. :pr:`23910`. | ||
|
|
||
| Presto Iceberg Changes |
There was a problem hiding this comment.
| Presto Iceberg Changes |
| * Add ``native_max_local_exchange_partition_count session`` property. :pr:`23910`. | ||
|
|
||
| Presto Iceberg Changes | ||
| ______________________ |
There was a problem hiding this comment.
| ______________________ |
|
|
||
| Presto Iceberg Changes | ||
| ______________________ | ||
| * Add test for logical type storage in parquet files :pr:`23388`. |
There was a problem hiding this comment.
Suggest deleting the three lines before this line to remove the Presto Iceberg Changes header, and this line should be moved to the Iceberg Connector Changes section.
|
|
||
| Presto Iceberg Changes | ||
| ______________________ | ||
| * Add test for logical type storage in parquet files :pr:`23388`. |
There was a problem hiding this comment.
| * Add test for logical type storage in parquet files :pr:`23388`. | |
| * Add test for logical type storage in Parquet files. :pr:`23388` |
| ______________________ | ||
| * Add test for logical type storage in parquet files :pr:`23388`. | ||
|
|
||
| Presto Parquet Changes |
There was a problem hiding this comment.
This heading does not appear in the Order of sections in the Release Notes Guidelines. I don't think that automatically makes it wrong, but I ask that other reviewers consider if the entry under this heading more properly belongs in General Changes or maybe another section in the Release Notes. If the entry Fix bug so... is moved, delete this Presto Parquet Changes heading.
There was a problem hiding this comment.
I would merge this into Hive and Iceberg sections (just duplicate for each).
There was a problem hiding this comment.
This was generated by the script? Why should we move it to other sections? I think keeping the parquet and orc changes separate allow for better readability since those are the high risk changes typically
There was a problem hiding this comment.
It's self-reported. I think keeping it separate is better because it's a property of the connector and it's confusing to subdivide Hive further into the storage formats it may use. If it's something we feel is important and shouldn't be missed, let's add it as a highlight.
|
Thanks @steveburnett for the intial review, I will go through the PR with no release notes to see if there are any more. Because of your enforcement throughout all PRs, this time most PRs have good release notes which I think is great! |
jaystarshot
force-pushed
the
release-notes-0.290
branch
2 times, most recently
from
9866f49 to
62c6a41
Compare
|
@steveburnett Extracted release notes from the non release notes PRs. Please review |
jaystarshot
force-pushed
the
release-notes-0.290
branch
2 times, most recently
from
b00a513 to
9066156
Compare
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the update with the new entries from the PRs with no release notes! Pulled updated branch, reviewed new local doc build.
Changes in this review:
-
Nits of punctuation and formatting, and a few suggested revisions.
-
Reviewed the the order of the headings as correctly following the sequence in the Order of sections of the Release Notes Guidelines. Thanks for rearranging that!
-
Please note the comments where I ask for a review of my suggested changes.
Not done:
The entries in the sections
- General Changes
- Presto C++ (Native Execution) Changes
- Iceberg Connector Changes
need to be rearranged to follow the Order of changes (Fix, Improve, Add, ...).
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
4c7106f to
bc0d700
Compare
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
d9de61e to
daeb03e
Compare
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the update! Pull updated branch, review new doc build. Just a few nits and suggestions left, nothing major.
jaystarshot
force-pushed
the
release-notes-0.290
branch
2 times, most recently
from
929bcc6 to
981f187
Compare
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
One, I think final, formatting nit that I should have caught earlier. Everything else looks great!
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
6209cf3 to
260baa5
Compare
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks! Found one more rephrasing (and relocation) suggestion, and a punctuation nit on a second additional start-to-finish review.
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
eeab87c to
9c4e636
Compare
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for fixing the nits in the last review!
Suggested revision for the newly-added entry.
Review of the full 0.290 release notes beginning to end found no other issues to comment on.
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
b7dbb88 to
b23e13b
Compare
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, review the output of a new local doc build. Thanks!
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
b23e13b to
6310574
Compare
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the highlights! Nits of formatting.
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, reviewed new doc build. Thanks!
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
121e10e to
fb77191
Compare
|
@tdcmeehan Can you take a quick pass before I merge? |
| * Fix ``task.writer-count`` and ``task.partitioned-writer-count`` configuration properties in Presto C++ for consistency with Presto. :pr:`23902` | ||
| * Fix a bug where users weren't able to set the ``native_expression.max_array_size_in_reduce`` session property. :pr:`23856` | ||
| * Fix plan validation failures for some join queries running with spill enabled when using Presto C++. :pr:`23595` | ||
| * Improve I/O and CPU usage by merging FilterNode into TableScanNode where possible. Also, added ``$path`` and ``$bucket`` to split info, and fixed the split counts in the coordinator UI. :pr:`23755` |
There was a problem hiding this comment.
Looks like this is reverted in 77, let's remove.
There was a problem hiding this comment.
this pr does 3 things and one is reverted
There was a problem hiding this comment.
OK, then let's rephrase to just the thing that was kept.
| * Remove session property ``native_join_spiller_partition_bits``. :pr:`23906` | ||
| * Revert merging of ``FilterNode`` into ``TableScanNode`` done in :pr:`23755`. :pr:`23855` | ||
|
|
||
| Security Changes |
There was a problem hiding this comment.
I'd try to reference CVEs that have been addressed. If that's too hard, let's just remove this section.
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
e50a74b to
06fa194
Compare
| * Fix plan validation failures for some join queries running with spill enabled when using Presto C++. :pr:`23595` | ||
| * Improve arbitrator configs to use the new string-based format. :pr:`23496` | ||
| * Add ``$path`` and ``$bucket`` to split info, and fixed the split counts in the coordinator UI. :pr:`23755` | ||
| * Add configurable chunk size in ChunkedSliceOutput, reducing total memory usage by nearly 3x and per-object memory by 4x with a 1kB chunk size (default 8kB). :pr:`23707` |
There was a problem hiding this comment.
I tried to understand how to toggle this, as it's written it's hard to understand how this relates to an operator of Presto. I recommend removing it or asking clarification from the author.
There was a problem hiding this comment.
Okay i asked the author didn't get a response yet. Won't want to block release notes for a PR. Also I think keeping in release notes is better if the people actually want to dig into code and see which operator it benefits but I am removing this entry
There was a problem hiding this comment.
Ideally this should be caught by whoever reviewed the PR. Let's remove it if it can't be easily described as a user-facing feature. CC: @chenyangfb @sdruzkin
| ______________________ | ||
| * Add test for logical type storage in parquet files :pr:`23388`. | ||
|
|
||
| Presto Parquet Changes |
There was a problem hiding this comment.
I would merge this into Hive and Iceberg sections (just duplicate for each).
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
47a69d8 to
2a9059d
Compare
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
2a9059d to
f02fd34
Compare
|
LGTM! |
jaystarshot
force-pushed
the
release-notes-0.290
branch
from
f02fd34 to
931e15e
Compare
3 participants
Fixes #23945
Missing Release Notes
Andrii Rosa
Bikramjeet Vig
Chen Yang
Jialiang Tan
Jimmy Lu
Joe Abraham
Naveen Nitturu
Pratik Joseph Dabre
Reetika Agrawal
Richard Barnes
using namespacefrom header files #23575 Removeusing namespacefrom header files (Merged by: Rebecca Schlussel)abhibongale
ajay-kharat
lithinpurushothaman
namya28
Extracted Release Notes
iceberg.max-statistics-file-cache-sizeconfiguration property. :pr:23177.inline_projections_on_valuesand configuration propertyoptimizer.inline-projections-on-valuesto evaluate project node on values node :pr:23245.ALTER TABLEstatement. :pr:23266.23386).23388.23388.23407.23456.metrics_max_inferred_columnto configure the max columns number for which metrics are collected, and supportmetrics_max_inferred_columnfor Iceberg table withPARQUETformat :pr:23468.23472.23479.23503.23510.is_private_ipthat returns true when the input IP address is private or a reserved IP address ... :pr:23520.native_max_partial_aggregation_memorywhich specifies presto native max partial aggregation memory when data reduction is not optimal :pr:23527.native_max_extended_partial_aggregation_memorywhich specifies presto native max partial aggregation memory when data reduction is optimal :pr:23527.native_max_spill_byteswhich specifies presto native max allowed spill bytes :pr:23527.23539.iceberg.parquet-batch-read-optimization-enabledis set toTRUE. :pr:23542.23546.rollback_to_timestampto rollback an iceberg table to a given point in time. :pr:23559.23579.23580./v1/info/stateto return INACTIVE state until the resource group configuration manager is fully initialized :pr:23585.23589.register_tableandunregister_table:pr:12345.hive.time-zone property.Partitioning,PartitioningScheme,PartitioningHandle,PlanFragmentId,StageExecutionDescriptorandSimplePlanFragmentto the SPI . :pr:23601.23626.async-cache-full-persistence-intervalwithasync-cache-persistence-interval. :pr:23626.23627.23627.eager-plan-validation-enabledfor eager building of validation of a logical plan before queuing. :pr:23649.ip_prefix_subnetsthat splits the input prefix into subnets the size of the new prefix length. ... :pr:23656.23710.23714.23739.23760.array_duplicatesand :func:array_has_duplicates.23774.:pr:23780.23792.23794.23797.23797.23850.23858.23863.23868.23868.23868.23868.23868.iceberg.rest.auth.oauth2.scopefor OAUTH2 authentication in Iceberg's REST catalog :pr:23884.23890.native_max_local_exchange_partition_count sessionproperty. :pr:23910.23922.All Commits
using namespacefrom header files (Removeusing namespacefrom header files #23575) (Richard Barnes)tabletotable_nameand update docs with correct argument names (Jalpreet Singh Nanda (:imjalpreet))