Turn on optimized_scale_writer_producer_buffer by default#23774
Merged
jaystarshot merged 1 commit intoprestodb:masterfrom Oct 7, 2024
Merged
Turn on optimized_scale_writer_producer_buffer by default#23774jaystarshot merged 1 commit intoprestodb:masterfrom
jaystarshot merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
|
Nit, suggest rephrasing release note entry to follow the Order of changes in the Release Notes Guidelines. From the PR description, maybe something like this? Please revise my suggestion if you have a better way to describe it. Also, I found the session property |
42b1271 to
62c0aea
Compare
tdcmeehan
approved these changes
Oct 7, 2024
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Found out a case where there was skew under the stage which is writing. This resulted in slow writer.
2ab2543 Presto already has a similar fix which is off by default. Turning it on helps but query is still a bit slower than no skew since the writers are scaling slower than the no skew case
trinodb/trino@4ddcb9e Trino's fix makes more sense and maybe it can be incorporated later
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.