Skip to content

Comments

[native] Add native_selective_nimble_reader_enabled session property#23721

Merged
amitkdutta merged 2 commits intoprestodb:masterfrom
Yuhta:tasks/T200762067/0
Sep 24, 2024
Merged

[native] Add native_selective_nimble_reader_enabled session property#23721
amitkdutta merged 2 commits intoprestodb:masterfrom
Yuhta:tasks/T200762067/0

Conversation

@Yuhta
Copy link
Contributor

@Yuhta Yuhta commented Sep 24, 2024

This is a hidden temporary session property to help controlled rollout of selective Nimble reader. Will be removed after the selective Nimble reader is fully rolled out.

This is a hidden temporary session property to help controlled rollout of
selective Nimble reader.  Will be removed after the selective Nimble reader is
fully rolled out.
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! Page builds and formats well. A suggestion about part of the definition.

Co-authored-by: Steve Burnett <burnett@pobox.com>
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks!

@Yuhta Yuhta marked this pull request as ready for review September 24, 2024 21:57
@Yuhta Yuhta requested review from a team and elharo as code owners September 24, 2024 21:57
@Yuhta Yuhta requested a review from presto-oss September 24, 2024 21:57
Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yuhta. Looks good.

@amitkdutta amitkdutta merged commit 62ca080 into prestodb:master Sep 24, 2024
@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants