Fix join validation when spill enabled for native#23595
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Sep 5, 2024
Merged
Fix join validation when spill enabled for native#23595amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta merged 1 commit intoprestodb:masterfrom
Conversation
9bafd7d to
08683f2
Compare
ValidateStreamingJoins tests that a join node has the necessary stream properties. When spill is enabled for Java, we need the probe side to have a fixed parallelism, but native does not have that requirement.. Fix ValidateStreamingJoins to not require an extra local exchange for spilling when using native execution.
08683f2 to
bc5d016
Compare
amitkdutta
approved these changes
Sep 5, 2024
Contributor
amitkdutta
left a comment
There was a problem hiding this comment.
Looks great! Thasnk @rschlussel for quickly fixing this long standing issue.
NikhilCollooru
approved these changes
Sep 5, 2024
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ValidateStreamingJoins tests that a join node has the necessary stream properties. When spill is enabled for Java, we need the probe side to have a fixed parallelism, but native does not have that requirement.. Fix ValidateStreamingJoins to not require an extra local exchange for spilling when using native execution.
Motivation and Context
Fix query failures like "java.lang.IllegalArgumentException: Probe side needs an additional local exchange for join: 17" when running with native execution with spill enabled
Impact
Fixes query failures for some join queries when spill and native execution are both enabled.
Test Plan
new tests
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.