Add scope for OAUTH2 authentication in Iceberg's REST catalog#23884
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Oct 24, 2024
Merged
Add scope for OAUTH2 authentication in Iceberg's REST catalog#23884tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
ZacBlanco
approved these changes
Oct 24, 2024
Contributor
|
@kiersten-stokes do you want to look at this? |
steveburnett
approved these changes
Oct 24, 2024
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks!
kiersten-stokes
approved these changes
Oct 24, 2024
Contributor
kiersten-stokes
left a comment
There was a problem hiding this comment.
Makes sense to me - thanks!
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Presto issue #23833
Motivation and Context
When we configure the
iceberg.rest.auth.oauth2.credentialproperty to connect to a Polaris catalog we get the errorThe scope is invalid.Since the Presto code does not set the 'scope' property, the Iceberg code is using 'catalog' as scope and the OAuth2 endpoint is considering it an invalid scope.
Impact
We cannot connect to the Polaris catalog using the iceberg.rest.auth.oauth2.credential property.
Test Plan
Modified tests in TestIcebergRestConfig
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.