[CLI] Add flag to disable certificate verification#23780
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Oct 8, 2024
Merged
[CLI] Add flag to disable certificate verification#23780tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
ZacBlanco
force-pushed
the
upstream-cli-insecure-mode
branch
from
fa9fff4 to
0aa72e5
Compare
Contributor
|
Nit for release note entry for consistency with the Order of changes in the Release Notes Guidelines. |
steveburnett
requested changes
Oct 7, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the doc, especially updating to capture other missing information that was not part of this PR! A minor nit of formatting, and otherwise looks great.
steveburnett
previously approved these changes
Oct 7, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local doc build, looks good.
ZacBlanco
force-pushed
the
upstream-cli-insecure-mode
branch
3 times, most recently
from
20336b6 to
c30c44e
Compare
Cherry-pick of trinodb/trino@1c5b9215a2d1b04b5f84e2b3e86 with minor modifications for Presto Co-authored-by: Lewuathe <lewuathe@me.com>
ZacBlanco
force-pushed
the
upstream-cli-insecure-mode
branch
from
c30c44e to
e56eda6
Compare
imjalpreet
approved these changes
Oct 7, 2024
Member
imjalpreet
left a comment
imjalpreet
left a comment
There was a problem hiding this comment.
Thank you, this is really useful for development and local debugging.
elharo
approved these changes
Oct 7, 2024
hantangwangd
approved these changes
Oct 8, 2024
tdcmeehan
approved these changes
Oct 8, 2024
25 tasks
prestodb-ci
requested review from
a team,
bibith4 and
namya28
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
--insecureflag to the CLI to skip SSL certificate verification.This is a cherry-pick of trinodb/trino@1c5b9215a2d1b04b5f84e2b3e86 with modifications to allow it to compile within PrestoDB
Motivation and Context
When deploying presto behind an SSL-enabled proxy or configuring it directly using systems like kubernetes, the system will issue self-signed certificates which can make debugging more difficult when clients have not been properly configured with the CA. When debugging clusters which are deployed this way it would be useful to be able to connect to them directly by just bypassing certificate verification.
Impact
Additional flag for the CLI
Test Plan
Contributor checklist
Release Notes