Extend MongoDB connector support binData#23386
Conversation
|
@tdcmeehan I create a new PR replace #23084 , please review again, Thank! |
jaystarshot
left a comment
There was a problem hiding this comment.
https://github.com/prestodb/presto/blob/master/presto-mongodb/src/test/java/com/facebook/presto/mongodb/TestMongoIntegrationSmokeTest.java#L102
I think extending these tests will be good
The varbinary TYPE test already exists |
|
Is any update needed to https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/connector/mongodb.rst for this PR? |
I think not anything need update |
tdcmeehan
left a comment
There was a problem hiding this comment.
Can you add a test in TestMongoIntegrationSmokeTest that proves the data can be read in a query?
I have add it. Please review again. Thank u |
|
Looks good @exxiang , please squash commits. Thank you! |
Please tell me if my squash is OK? |
|
@exxiang there is still a merge commit. https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together |
49619a9 to
0cb7760
Compare
Please review again. Thank U! Thank U! Thank U! |
|
@exxiang can you please add a release note? It seems we're adding new data type support, which is relevant. |
sure I has already add it |
Description
Extend MongoDB connector support binData
Motivation and Context
Extend MongoDB connector support [binData] #23083
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.