Skip to content

Comments

Extend MongoDB connector support binData#23386

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
exxiang:mongodb-support-bindata
Aug 27, 2024
Merged

Extend MongoDB connector support binData#23386
tdcmeehan merged 1 commit intoprestodb:masterfrom
exxiang:mongodb-support-bindata

Conversation

@exxiang
Copy link
Contributor

@exxiang exxiang commented Aug 6, 2024

Description

Extend MongoDB connector support binData

Motivation and Context

Extend MongoDB connector support [binData] #23083

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

MongoDB Connector
* Support varbinary data type in MongoDB (pr:`23386`)

@exxiang exxiang requested a review from a team as a code owner August 6, 2024 03:29
@exxiang exxiang requested a review from presto-oss August 6, 2024 03:29
@exxiang
Copy link
Contributor Author

exxiang commented Aug 6, 2024

@tdcmeehan I create a new PR replace #23084 , please review again, Thank!

@tdcmeehan tdcmeehan self-assigned this Aug 6, 2024
Copy link
Member

@jaystarshot jaystarshot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exxiang
Copy link
Contributor Author

exxiang commented Aug 7, 2024

@steveburnett
Copy link
Contributor

@exxiang
Copy link
Contributor Author

exxiang commented Aug 8, 2024

Is any update needed to https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/connector/mongodb.rst for this PR?

I think not anything need update

Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test in TestMongoIntegrationSmokeTest that proves the data can be read in a query?

@exxiang
Copy link
Contributor Author

exxiang commented Aug 19, 2024

Can you add a test in TestMongoIntegrationSmokeTest that proves the data can be read in a query?

I have add it. Please review again. Thank u

@tdcmeehan
Copy link
Contributor

Looks good @exxiang , please squash commits. Thank you!

@exxiang
Copy link
Contributor Author

exxiang commented Aug 22, 2024

Looks good @exxiang , please squash commits. Thank you!

Please tell me if my squash is OK?

@tdcmeehan
Copy link
Contributor

tdcmeehan commented Aug 22, 2024

@exxiang exxiang force-pushed the mongodb-support-bindata branch from 49619a9 to 0cb7760 Compare August 26, 2024 02:42
@exxiang
Copy link
Contributor Author

exxiang commented Aug 26, 2024

@exxiang there is still a merge commit. https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together

Please review again. Thank U! Thank U! Thank U!

@tdcmeehan
Copy link
Contributor

@exxiang can you please add a release note? It seems we're adding new data type support, which is relevant.

@exxiang
Copy link
Contributor Author

exxiang commented Aug 27, 2024

@exxiang can you please add a release note? It seems we're adding new data type support, which is relevant.

sure I has already add it

@tdcmeehan tdcmeehan merged commit 581eb87 into prestodb:master Aug 27, 2024
@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants