[presto-orc] Fix row index position when compression is disabled#23760
Merged
NikhilCollooru merged 1 commit intoprestodb:masterfrom Oct 2, 2024
Merged
[presto-orc] Fix row index position when compression is disabled#23760NikhilCollooru merged 1 commit intoprestodb:masterfrom
NikhilCollooru merged 1 commit intoprestodb:masterfrom
Conversation
Summary: Fix a bug in position accounting in the OrcOutputBuffer when doing batched writeBytes. Differential Revision: D63733934
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D63733934 |
elharo
approved these changes
Oct 2, 2024
NikhilCollooru
approved these changes
Oct 2, 2024
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug in position accounting in the OrcOutputBuffer when doing batched writeBytes.
This bug results in incorrect row index when the file is not compressed,
and one or more writeBytes calls have an input larger than the size of the
compression buffer, and that stripe has 2+ row groups.
Incorrect row index will result in incorrect reads when using presto-orc
reader.
Motivation and Context
Impact
Fix data corruption when an ORC/DWRF file is not compressed and one of the string or binary
column values is larger than the compression buffer size.
Test Plan
Updated unit tests.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.