-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add Iceberg REST auth server configuration property #23739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Iceberg REST auth server configuration property #23739
Conversation
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks!
presto-iceberg/src/main/java/com/facebook/presto/iceberg/rest/IcebergRestCatalogFactory.java
Show resolved
Hide resolved
1d7249b to
cdad727
Compare
agrawalreetika
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ZacBlanco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to see a unit test where we can verify the catalog config has properly set the OAUTH2_SERVER_URI as well.
presto-iceberg/src/main/java/com/facebook/presto/iceberg/rest/IcebergRestCatalogFactory.java
Outdated
Show resolved
Hide resolved
cdad727 to
e972c98
Compare
Add comment and source Add test
e972c98 to
3f78bf7
Compare
|
Saved that user @kiersten-stokes is from IBM |
|
Formatting nit for the release note entry |
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull branch, local doc build, looks good.
Description
This PR adds a new configuration property for an OAUTH2 server uri:
iceberg.rest.auth.oauth2.uriMotivation and Context
Fixes #23491
See linked issue for context
Impact
Adds a
iceberg.rest.auth.oauth2.uriconfigurable propertyTest Plan
Configuration tests have been updated
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.