[native] Add session property for partial aggregation and spill

[kewang1024]

== RELEASE NOTES ==

General Changes
* Add a session property `native_max_partial_aggregation_memory` which specifies presto native max partial aggregation memory when data reduction is not optimal :pr:`23527`
* Add a session property `native_max_extended_partial_aggregation_memory` which specifies presto native max partial aggregation memory when data reduction is optimal :pr:`23527`
* Add a session property `native_max_spill_bytes ` which specifies presto native max allowed spill bytes :pr:`23527`

[steveburnett]

Should this be documented on https://prestodb.io/docs/current/presto_cpp/properties.html ?

[xiaoxmeng]

@kewang1024 LGTM. Thanks!

[xiaoxmeng]

@kewang1024 do we still have the sanity check for the native session conversion in Prestissimo? Thanks!

[xiaoxmeng]

Do you want to expose max_extended_partial_aggregation_memory as well? Velox supports to dynamically adjust aggregation memory limit in a range defined by the above two configs? Thanks!

[kewang1024]

Should this be documented on https://prestodb.io/docs/current/presto_cpp/properties.html ?

Actually this is session property which is different than the configs, so should not be added here.
But we can start a new wiki to document the session properties, do you think you can help with setting up new page? @steveburnett

[aditi-pandit]

Thanks @kewang1024 for this code.

Also as per @steveburnett's comment we should document atleast native_max_spill_bytes at https://prestodb.io/docs/current/presto_cpp/properties.html

[aditi-pandit]

It might be good to specify all the operators (Hashjoin, HashAgg, OrderBy, RowNumber, Window etc) to which this value applies

[kewang1024]

I don't have much context on spilling so might not have the full list, @xiaoxmeng do you know the full list?

I can add in a separate PR. We need this change to make an internal release cut.

[xiaoxmeng]

@kewang1024 @aditi-pandit: this applies at task level and is not specific to a particular operator.

[yingsu00]

@kewang1024 This PR needs the release note. Will you be able to add one? Thanks.

[steveburnett]

Should this be documented on https://prestodb.io/docs/current/presto_cpp/properties.html ?

Actually this is session property which is different than the configs, so should not be added here. But we can start a new wiki to document the session properties, do you think you can help with setting up new page? @steveburnett

Like the Presto Properties Reference page, the Presto C++ Properties Reference page begins with the statement "The following pages are not a complete list of all configuration and session properties ".

I know the sentence before that reads "This section describes Presto C++ configuration properties." which is exclusionary, but that could be changed to "This section describes Presto C++ configuration and session properties." and we don't have a separate session properties page in the Presto doc. (Maybe we should.)

I don't think we need a separate page for Presto C++ session properties, so I think all three of these session properties could be added to Presto C++ Properties Reference.

We could highlight the distinction for session properties in the description. For example, in your current draft adding max_spill_bytes to Presto C++ Properties Reference, the description could read "This session property (my new words emphasized here for clarity) specifies the max spill bytes limit set for each query."

If you or others feel strongly we need a separate page for Presto C++ Session Properties, I am open to the idea. Help me understand why a separate page is important.