Skip to content

Comments

CVE-2024-1597 updated postgres version to 42.6.1#23710

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
adkharat:postgres_version_upgrade
Sep 25, 2024
Merged

CVE-2024-1597 updated postgres version to 42.6.1#23710
tdcmeehan merged 1 commit intoprestodb:masterfrom
adkharat:postgres_version_upgrade

Conversation

@adkharat
Copy link
Contributor

@adkharat adkharat commented Sep 24, 2024

Description

CVE-2024-1597
Security fix for postgresql
vulnerable version : 4.6.0
Fixed version : 4.6.1

Updated postgresql version from 4.6.0 to 4.6.1 in root pom.xml

Motivation and Context

pgjdbc, the PostgreSQL JDBC Driver, allows attacker to inject SQL if using PreferQueryMode=SIMPLE. Note this is not the default. In the default mode there is no vulnerability. A placeholder for a numeric value must be immediately preceded by a minus. There must be a second placeholder for a string value after the first placeholder; both must be on the same line. By constructing a matching string payload, the attacker can inject SQL to alter the query,bypassing the protections that parameterized queries bring against SQL Injection attacks. Versions before 42.7.2, 42.6.1, 42.5.5, 42.4.4, 42.3.9, and 42.2.28 are affected.

Impact

Image scan report showed the vulnerability has been removed

correlation-report-ibm-lh-presto-postgres.csv

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== RELEASE NOTES ==

Security Changes
* Upgrade Postgres JDBC Driver to 42.6.1 :pr:`23710`

@adkharat adkharat requested a review from a team as a code owner September 24, 2024 09:29
@adkharat adkharat requested a review from presto-oss September 24, 2024 09:29
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 24, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: adkharat / name: Ajay Kharat (543e37e)

@adkharat adkharat changed the title updated postgres version to 42.6.1 CVE-2024-1597 updated postgres version to 42.6.1 Sep 24, 2024
@adkharat
Copy link
Contributor Author

@imjalpreet Could you please review the PR.

Copy link
Member

@imjalpreet imjalpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adkharat Thanks for the fix! LGTM 👍🏼

Can you please sign the CLA? You should be able to see a comment with the instructions above.

@imjalpreet
Copy link
Member

The email address for the commit (910e100) is not linked to the GitHub account

@adkharat It looks like the email ID you used while committing is not linked to your GitHub account. There are two ways to solve this: you can link that email ID with your GitHub account or please amend your commit and use the email ID of the GitHub account you are using.

If you decide to go with the first option, you can link a new email to your existing GitHub account by going to Settings->Emails->Add email address

Copy link
Member

@imjalpreet imjalpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small request: Please update the commit message to: Upgrade Postgres JDBC Driver to 42.6.1

@steveburnett
Copy link
Contributor

A small request: Please update the commit message to: Upgrade Postgres JDBC Driver to 42.6.1

Yes, please, following the Release Notes Guidelines. For example:

== RELEASE NOTES ==

Security Changes
* Upgrade Postgres JDBC Driver to 42.6.1 :pr:`23710`

@adkharat adkharat force-pushed the postgres_version_upgrade branch from 910e100 to c6a7c8c Compare September 25, 2024 03:41
@adkharat adkharat force-pushed the postgres_version_upgrade branch from c6a7c8c to 543e37e Compare September 25, 2024 03:47
@adkharat
Copy link
Contributor Author

A small request: Please update the commit message to: Upgrade Postgres JDBC Driver to 42.6.1

Done

@adkharat
Copy link
Contributor Author

adkharat commented Sep 25, 2024

A small request: Please update the commit message to: Upgrade Postgres JDBC Driver to 42.6.1

Yes, please, following the Release Notes Guidelines. For example:

== RELEASE NOTES ==

Security Changes
* Upgrade Postgres JDBC Driver to 42.6.1 :pr:`23710`

@steveburnett Done

@adkharat
Copy link
Contributor Author

adkharat commented Sep 25, 2024

@adkharat Thanks for the fix! LGTM 👍🏼

Can you please sign the CLA? You should be able to see a comment with the instructions above.

@imjalpreet Done

@imjalpreet
Copy link
Member

@adkharat Thanks, LGTM.

@tdcmeehan tdcmeehan merged commit 2242d6c into prestodb:master Sep 25, 2024
@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
25 tasks
@tdcmeehan tdcmeehan added the from:IBM PR from IBM label Dec 13, 2024
@prestodb-ci prestodb-ci requested review from a team, pdabre12 and sh-shamsan and removed request for a team December 13, 2024 15:29
@prestodb-ci prestodb-ci requested a review from a team April 3, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants