Skip to content

Comments

Add sidecars to NodeManager and add PluginNodeManager#23863

Merged
pdabre12 merged 1 commit intoprestodb:masterfrom
pdabre12:add-node-manager
Oct 21, 2024
Merged

Add sidecars to NodeManager and add PluginNodeManager#23863
pdabre12 merged 1 commit intoprestodb:masterfrom
pdabre12:add-node-manager

Conversation

@pdabre12
Copy link
Contributor

@pdabre12 pdabre12 commented Oct 21, 2024

Description

Adds a new NodeManager : PluginNodeManager.

Test Plan

Unit tests included.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General changes
* Adds a new NodeManager : 'PluginNodeManager' :pr:`23863`

@pdabre12 pdabre12 marked this pull request as ready for review October 21, 2024 19:42
@pdabre12 pdabre12 requested a review from a team as a code owner October 21, 2024 19:42
@pdabre12 pdabre12 requested a review from presto-oss October 21, 2024 19:42
@pdabre12
Copy link
Contributor Author

CC: @rschlussel

@pdabre12
Copy link
Contributor Author

@rschlussel The pipeline is green now, can you take another look? Thanks.

@pdabre12 pdabre12 merged commit 7e6691d into prestodb:master Oct 21, 2024
@pdabre12 pdabre12 deleted the add-node-manager branch October 21, 2024 23:42
@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants