[native] Switch to use string based arbitrator configs#23496
[native] Switch to use string based arbitrator configs#23496tanjialiang merged 1 commit intoprestodb:masterfrom
Conversation
tanjialiang
requested review from
a team,
elharo and
steveburnett
as code owners
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the doc! Just some nits of formatting, the content looks great.
| zero, then there is no timeout. | ||
|
|
||
| ``shared-arbitrator.fast-exponential-growth-capacity-limit`` | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|
|
||
| When shared arbitrator grows memory pool's capacity, the growth bytes will | ||
| be adjusted in the following way: | ||
| - If 2 * current capacity is less than or equal to |
There was a problem hiding this comment.
/Users/steveburnett/Documents/GitHub/presto/presto-docs/src/main/sphinx/presto_cpp/properties.rst:211: ERROR: Unexpected indentation.
Adjust the indentation for this list until the gray vertical line in the screenshot does not appear in a local doc build. See Building the documentation in the presto-docs README for information on local doc builds.
There was a problem hiding this comment.
Thanks, just revised
tanjialiang
force-pushed
the
rm_arb_conf
branch
from
a126c4e to
738ff75
Compare
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@tanjialiang LGTM. Thanks!
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thank you for the quick revision! I took another look and found some more nits of formatting and phrasing, but I think this should be everything.
tanjialiang
force-pushed
the
rm_arb_conf
branch
from
738ff75 to
7ca06e0
Compare
Hi @steveburnett , just addressed your comments. Would you help to take another look? Thanks |
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new doc build, looks good. Thanks!
5 participants
Description
As we move forward with adopting the new string based configurations for implementation specific arbitrator configs, we are removing the old configs and migrate the configs to the new shared arbitrator configs.
Shared arbitrator related configs are renamed to the following:
shared-arbitrator.reserved-capacity
shared-arbitrator.memory-pool-initial-capacity
shared-arbitrator.global-arbitration-enabled
shared-arbitrator.memory-pool-reserved-capacity
shared-arbitrator.memory-pool-transfer-capacity
shared-arbitrator.memory-reclaim-max-wait-time
(new) shared-arbitrator.fast-exponential-growth-capacity-limit
(new) shared-arbitrator.slow-capacity-grow-pct
(new) shared-arbitrator.memory-pool-min-free-capacity
(new) shared-arbitrator.memory-pool-min-free-capacity-pct