Upgraded protobuf-java dependencies to 3.25.5#23797
Merged
tdcmeehan merged 2 commits intoprestodb:masterfrom Oct 23, 2024
Merged
Upgraded protobuf-java dependencies to 3.25.5#23797tdcmeehan merged 2 commits intoprestodb:masterfrom
tdcmeehan merged 2 commits intoprestodb:masterfrom
Conversation
Member
|
Should we upgrade it to some close to latest version may be |
| <dependency> | ||
| <groupId>com.google.protobuf</groupId> | ||
| <artifactId>protobuf-java-util</artifactId> | ||
| <version>${dep.protobuf-java.version}</version> |
Member
There was a problem hiding this comment.
Do we need to add this explicitly?
Contributor
Author
There was a problem hiding this comment.
If we don't, 2.24.0 will be brought in by another dependency.
Contributor
Author
|
@agrawalreetika protobuf versions 3.x and 4.x have different APIs and upgrading the major version might result in issues. https://protobuf.dev/support/version-support/ |
agrawalreetika
previously approved these changes
Oct 10, 2024
Member
|
Looks like there are some dependency issues in |
agrawalreetika
approved these changes
Oct 19, 2024
tdcmeehan
approved these changes
Oct 23, 2024
25 tasks
prestodb-ci
requested review from
a team,
pdabre12 and
wanglinsong
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgraded protobuf-java dependencies to version 3.25.5
Motivation and Context
This upgrade was created to deal with CVEs found in lower versions
Impact
None
Release Notes