Remove array_dupes and array_has_dupes alias.#23762
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Oct 2, 2024
Merged
Remove array_dupes and array_has_dupes alias.#23762amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta merged 1 commit intoprestodb:masterfrom
Conversation
NikhilCollooru
approved these changes
Oct 2, 2024
Contributor
NikhilCollooru
left a comment
NikhilCollooru
left a comment
There was a problem hiding this comment.
If there are any pipelines using these aliases, they will fail. We should make a post in the Presto FYI group to inform the users
amitkdutta
added a commit
to amitkdutta/velox
that referenced
this pull request
Oct 2, 2024
Summary: Removing deprecated function alias for array_duplicates and array_has_duplicates. We have already removed this from Presto prestodb/presto#23762 Differential Revision: D63771171
amitkdutta
added a commit
to amitkdutta/velox
that referenced
this pull request
Oct 2, 2024
…r#11150) Summary: Removing deprecated function alias for array_duplicates and array_has_duplicates. We have already removed this from Presto prestodb/presto#23762 Reviewed By: kgpai Differential Revision: D63771171
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Oct 2, 2024
Summary: Pull Request resolved: #11150 Removing deprecated function alias for array_duplicates and array_has_duplicates. We have already removed this from Presto prestodb/presto#23762 Reviewed By: kgpai Differential Revision: D63771171 fbshipit-source-id: 90d25755cf037489611633acb52caa4bc3d3247f
25 tasks
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…r#11150) Summary: Pull Request resolved: facebookincubator#11150 Removing deprecated function alias for array_duplicates and array_has_duplicates. We have already removed this from Presto prestodb/presto#23762 Reviewed By: kgpai Differential Revision: D63771171 fbshipit-source-id: 90d25755cf037489611633acb52caa4bc3d3247f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing non-standard alias names array_dupes and array_has_dupes. These were moved to alias and removed from documentation in 2021.
Motivation and Context
Keeping function names standard.
Impact
If there is any legacy usage of these aliases, those needs to be migrated to standard names. Standard name
array_duplicatesandarray_has_duplicatesare already available and no change is done there.Test Plan
Existing tests and removed test with alias.
Release Notes
Please follow release notes guidelines and fill in the release notes below.