Refactor the ContainerQueryRunner to utilize the JDBC driver for executing queries#23784
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Oct 17, 2024
Merged
Refactor the ContainerQueryRunner to utilize the JDBC driver for executing queries#23784tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
Joe-Abraham
force-pushed
the
cli
branch
3 times, most recently
from
9ec91a4 to
5338355
Compare
tdcmeehan
reviewed
Oct 10, 2024
Contributor
tdcmeehan
left a comment
tdcmeehan
left a comment
There was a problem hiding this comment.
Directionally this looks fine.
Joe-Abraham
force-pushed
the
cli
branch
6 times, most recently
from
3e41383 to
3765257
Compare
Joe-Abraham
changed the title
tdcmeehan
requested changes
Oct 15, 2024
| catch (InterruptedException e) { | ||
| throw new RuntimeException(e); | ||
| catch (SQLException e) { | ||
| e.printStackTrace(); |
Contributor
Author
There was a problem hiding this comment.
Updated the code.
Comment on lines
399
to
401
| // Log or handle unknown type names | ||
| System.out.println("Unknown SQL type name: " + typeName); | ||
| return UnknownType.UNKNOWN; |
Contributor
Author
There was a problem hiding this comment.
Updated the code.
Joe-Abraham
force-pushed
the
cli
branch
2 times, most recently
from
2193ae1 to
8f7e9e0
Compare
tdcmeehan
reviewed
Oct 16, 2024
| Connection connection = DriverManager.getConnection(url, "test", null); | ||
| statement = connection.createStatement(); | ||
| } | ||
| catch (Exception e) { |
Contributor
There was a problem hiding this comment.
What is thrown here? If it's an IOException, can we let it simply throw?
Contributor
Author
There was a problem hiding this comment.
It is an SQLException.
Contributor
|
Commit message is too long. Perhaps |
Contributor
Author
|
Updated the commit message |
tdcmeehan
approved these changes
Oct 16, 2024
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor the ContainerQueryRunner to utilize the JDBC driver for executing queries.