Add support to query Iceberg table by branch/tag name#23539
Add support to query Iceberg table by branch/tag name#23539agrawalreetika merged 2 commits intoprestodb:masterfrom
Conversation
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks!
|
Nit, update the PR number in the release note entry from the default |
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergAbstractMetadata.java
Outdated
Show resolved
Hide resolved
ZacBlanco
left a comment
There was a problem hiding this comment.
code and tests LGTM, one suggestion on the error message
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergAbstractMetadata.java
Outdated
Show resolved
Hide resolved
a496bc2 to
f8bcd71
Compare
f8bcd71 to
e935a0a
Compare
hantangwangd
left a comment
There was a problem hiding this comment.
Should we add some test cases about query on schema changes? Referring to: https://iceberg.apache.org/docs/nightly/branching/#schema-selection-with-branches-and-tags. It seems that Iceberg has some differences in handling queries on branch and tag.
If any schema changes are performed after tag creation, Tag based query access uses the snapshot's schema. |
OK, got it. |
e935a0a to
e066ac7
Compare
hantangwangd
left a comment
There was a problem hiding this comment.
Thanks for adding this feature. Change looks good to me since we have not yet decide how to choose the schema of queries on tag and snapshot.
|
@tdcmeehan @ZacBlanco Can you check on this one? |
|
@steveburnett Could you please review the docs changes? |
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks!
Description
Add support to query Iceberg table by branch/tag name
Motivation and Context
Resolves #22029
Impact
Resolves #22029
Test Plan
Added tests
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.