Conversation
elharo
reviewed
Sep 4, 2024
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
should the icon file be in this PR?
auden-woolfson
force-pushed
the
add_logo
branch
from
6a2e20e to
7481ae0
Compare
Contributor
|
LGTM. Reword commit message to |
auden-woolfson
force-pushed
the
add_logo
branch
from
7481ae0 to
2d653c7
Compare
tdcmeehan
approved these changes
Sep 6, 2024
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hudi has something similar to this for development, looks nice when selecting projects in IntelliJ