Skip to content

[native] Propagate table writer concurrency settings#23902

Merged
arhimondr merged 1 commit intoprestodb:masterfrom
arhimondr:prestission-propagate-table-writer-settings
Oct 29, 2024
Merged

[native] Propagate table writer concurrency settings#23902
arhimondr merged 1 commit intoprestodb:masterfrom
arhimondr:prestission-propagate-table-writer-settings

Conversation

@arhimondr
Copy link
Member

Description

  • task.writer-count
  • task.partitioned-writer-count

Motivation and Context

Keep it consistent with Presto

Test Plan

Use HiveExternalWorkerQueryRunner to validate

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Native
* Respect `task.writer-count` and `task.partitioned-writer-count` configuration properties

@arhimondr arhimondr requested a review from a team as a code owner October 28, 2024 21:42
@arhimondr arhimondr requested a review from xiaoxmeng October 28, 2024 21:42
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arhimondr LGTM. Thanks!

@arhimondr arhimondr force-pushed the prestission-propagate-table-writer-settings branch from 009a012 to e2b0a1a Compare October 29, 2024 14:27
@arhimondr arhimondr merged commit 38ca2ec into prestodb:master Oct 29, 2024
@arhimondr arhimondr deleted the prestission-propagate-table-writer-settings branch October 29, 2024 16:37
@steveburnett
Copy link
Contributor

Suggest revising the release notes entry for consistency with the Order of changes in the Release Notes Guidelines, and include the PR number. Please revise my suggestion if it does not describe the PR accurately.

== RELEASE NOTES ==
Prestissimo (Native Execution) Changes
* Fix `task.writer-count` and `task.partitioned-writer-count` configuration properties in Presto C++ for consistency with Presto. :pr:`23902`

@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
25 tasks
@jaystarshot
Copy link
Member

Using @steveburnett's suggestion for release notes

@tdcmeehan tdcmeehan added the from:Meta PR from Meta label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments