Fix for incorrect nullable setting on NOT NULL columns#23577
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Sep 13, 2024
Merged
Fix for incorrect nullable setting on NOT NULL columns#23577tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
|
Can you add a test for this? |
rschlussel
reviewed
Sep 5, 2024
Contributor
rschlussel
left a comment
There was a problem hiding this comment.
Thanks for this fix! Can you add a test?
Contributor
Author
Added test, Could you please review now. |
rschlussel
approved these changes
Sep 6, 2024
27fc75a to
81a69ff
Compare
Contributor
|
Looks good, please clean up commit message
|
81a69ff to
bc34e63
Compare
Contributor
Author
The commit message has been cleaned up, Could you please review now. |
tdcmeehan
approved these changes
Sep 12, 2024
25 tasks
Contributor
|
Saved that user @NaveenNitturu is from IBM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Information schema was returning NULLABLE as YES irrespective of what is been set actually while creating the table.
This PR will fetch the columns details (is NULLABLE ?) details based on how the table was created.
Motivation and Context
This change is essential to address a specific issue on the information schema tables. The problem revolves around the occurrence of default YES in NULLABLE field while querying the information.schema tables to get the metadata details.
Impact
Added fix to fetch the columns details (is NULLABLE ?) details based on how the table was created.
Test Plan
Tested the fix by creating a table having column with NULLABLE and NOT NULLABLE columns.

Tried querying the metadata of the table from the information schema and the details were populated correctly.
Before Fix:
After Fix:

Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.