Skip to content

Comments

Fix some toString methods in presto-orc#23750

Merged
sdruzkin merged 1 commit intoprestodb:masterfrom
sdruzkin:export-D63643493
Oct 3, 2024
Merged

Fix some toString methods in presto-orc#23750
sdruzkin merged 1 commit intoprestodb:masterfrom
sdruzkin:export-D63643493

Conversation

@sdruzkin
Copy link
Collaborator

@sdruzkin sdruzkin commented Sep 30, 2024

Description

Fix some incorrectly formatted toString methods.

Motivation and Context

Impact

Test Plan

mvn test

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@sdruzkin sdruzkin requested a review from a team as a code owner September 30, 2024 17:02
@sdruzkin sdruzkin requested a review from presto-oss September 30, 2024 17:02
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D63643493

sdruzkin added a commit to sdruzkin/presto that referenced this pull request Oct 1, 2024
Summary: Pull Request resolved: prestodb#23750

Differential Revision: D63643493
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D63643493

sdruzkin added a commit to sdruzkin/presto that referenced this pull request Oct 1, 2024
Summary: Pull Request resolved: prestodb#23750

Differential Revision: D63643493
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D63643493

Summary: Pull Request resolved: prestodb#23750

Differential Revision: D63643493
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D63643493

@sdruzkin
Copy link
Collaborator Author

sdruzkin commented Oct 1, 2024

@ajaygeorge can you please stamp this PR? Elliotte does not have committer status for presto-orc.

@elharo
Copy link
Contributor

elharo commented Oct 2, 2024

It's annoying that you can't merge this very simple and obviously correct and safe PR even though you are a committer on presto-orc. Really, presto is way too picky about who must stamp and approve what. Both Google and Meta have less stringent rules than this for their much larger and more diverse internal repositories, and it works just fine.

@sdruzkin sdruzkin requested review from NikhilCollooru and removed request for ajaygeorge October 2, 2024 23:14
@sdruzkin sdruzkin merged commit 751768a into prestodb:master Oct 3, 2024
Mariamalmesfer pushed a commit to Mariamalmesfer/presto that referenced this pull request Oct 14, 2024
Summary: Pull Request resolved: prestodb#23750

Differential Revision: D63643493
@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants