Fix UUID distinct operation issue#23732
Fix UUID distinct operation issue#23732tdcmeehan merged 1 commit intoprestodb:masterfrom abhibongale:distinct-operation-on-uuid-fails
Conversation
|
|
|
Code looks good @abhibongale, thanks for the pull request! It looks like this is a cherry pick from Trino. Please attribute it in the commit message (see contributing guide). |
|
Almost there. Please use this commit message which will show attribution in Github. |
| } | ||
|
|
||
| @Test | ||
| public void testUuidDistinct() |
There was a problem hiding this comment.
@BryanCutler : We should check how this works in Prestissimo as well. Don't anticipate a problem, but it would be good to make it part of the tests.
imjalpreet
left a comment
There was a problem hiding this comment.
@abhibongale Thanks for the contribution, I have re-triggered your failed test.
A small request, please rebase your branch on master rather than using merge. Merge results in an extra commit as you can see.
Cherry-pick of trinodb/trino#1180 by guyco33 Co-authored-by: Guy Cohen <guyco33@gmail.com>
|
Please consider adding release notes following our release notes guide - link. Using below for now |
Description
This commit resolves an issue with the UUID type in PrestoDB, where performing a GROUP BY operation on UUIDs resulted in an UnsupportedOperationException. The fix aligns with a solution implemented in Trino, ensuring that UUID comparison works correctly during aggregation.
Motivation and Context
This change is required to allow users to perform GROUP BY operations on UUIDs without encountering errors. It addresses the bug reported in issue #23554, enabling proper usage of UUIDs in queries.
Test Plan
The solution was tested by adding unit tests in TestDistinctAggregations, which cover various scenarios of using distinct operations on UUIDs. All tests passed successfully, confirming the correctness of the implementation.
Contributor checklist
Release Notes
23732.