[native] Add session properties for expression evaluation optimizations#23620
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Sep 12, 2024
Merged
Conversation
bikramSingh91
requested review from
a team,
elharo and
steveburnett
as code owners
Contributor
Author
|
This change relies on velox submodule to be updated to include (facebookincubator/velox#10902), I will send out a separate PR for updating the module. |
Contributor
Author
|
Depends on #23621 |
steveburnett
requested changes
Sep 11, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the doc! Looks good in a local doc build, just a few minor nits.
This change adds session properties that are eventually translate to velox query configs to toggle optimization in expression evaluation. These are debug only configs and should not be used in production. The configs added are: `native_debug_disable_expression_with_peeling`, `native_debug_disable_common_sub_expressions`, `native_debug_disable_expression_with_memoization`, `native_debug_disable_expression_with_lazy_inputs`. Test Plan: Updated and added unit tests
bikramSingh91
force-pushed
the
native_expr_configs
branch
from
0168180 to
ea8b4c7
Compare
steveburnett
approved these changes
Sep 11, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks!
spershin
requested review from
mbasmanova,
rschlussel,
tdcmeehan and
xiaoxmeng
NikhilCollooru
approved these changes
Sep 11, 2024
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds session properties that are eventually translate to
velox query configs to toggle optimization in expression evaluation.
These are debug only configs and should not be used in production.
The configs added are:
native_debug_disable_expression_with_peeling,native_debug_disable_common_sub_expressions,native_debug_disable_expression_with_memoization,native_debug_disable_expression_with_lazy_inputs.Test Plan:
Updated and added unit tests