Security Vulnerability fix for logback-core (CVE-2023-6378)#23735
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Oct 9, 2024
Merged
Security Vulnerability fix for logback-core (CVE-2023-6378)#23735tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
The committers listed above are authorized under a signed CLA. |
Member
|
@namya28 Please sign a CLA, it's needed for the first PR - https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#contributing-to-presto Also let's make 2 changes -
|
6addf86 to
c7287c6
Compare
c7287c6 to
d1a3a3f
Compare
agrawalreetika
approved these changes
Sep 30, 2024
Contributor
|
Thanks for this! Nit in formatting of the release note entry Also, you should delete this part If release note is NOT required, use: |
tdcmeehan
approved these changes
Oct 9, 2024
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is for fixing the security vulnerability for the library "logback-core". The version has been upgraded to 1.2.13 (https://mvnrepository.com/artifact/ch.qos.logback/logback-core/1.2.13) from the version 1.2.3 (https://mvnrepository.com/artifact/ch.qos.logback/logback-core/1.2.3) in the root pom.xml file as the version 1.2.3 had a security vulnerability. This fixes CVE-2023-6378.
Motivation and Context
A Pull Request (PR) was initially raised to remove the logback-core dependency for the version 1.2.3. The link to the PR: #21819. However, the logback-core dependency is being transitively used in presto modules for the version 1.2.3 : (Attaching screenshots for reference)

1. presto-spark-testing
2. presto-router

3. presto-benchmark-runner

4. presto-proxy

5. presto-benchto-benchmarks

6. presto-verifier

7. presto-native-execution

Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.