Avoid pushdown of negative position for element_at as subfield pruning for array #23479
Merged
jp-sivaprasad merged 1 commit intoprestodb:masterfrom Aug 23, 2024
Conversation
|
|
636e226 to
473b72e
Compare
elharo
reviewed
Aug 21, 2024
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Outdated
Show resolved
Hide resolved
473b72e to
2e3cea5
Compare
elharo
previously approved these changes
Aug 21, 2024
tdcmeehan
requested changes
Aug 21, 2024
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Outdated
Show resolved
Hide resolved
2e3cea5 to
5ec446d
Compare
Contributor
|
Please reword commit message per our guidelines in CONTRIBUTING. Perhaps |
5c7eec1 to
44ac434
Compare
44ac434 to
be2dcc8
Compare
tdcmeehan
approved these changes
Aug 23, 2024
Contributor
|
Please add a release note @jp-sivaprasad |
25 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently negative array subscript (for example, an array index of -2, for element_at ) is pushed down as subfield pruning, and worker is not sanity checking against it causing IllegalArgumentException
(Issue : #22690)
The fix is to avoid pushing down negative position for element_at for array, in PushdownSubfields.toSubfield()
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.