[native] Add counter to track effectiveness of memory pushback#23813
Merged
xiaoxmeng merged 1 commit intoprestodb:masterfrom Oct 12, 2024
Merged
[native] Add counter to track effectiveness of memory pushback#23813xiaoxmeng merged 1 commit intoprestodb:masterfrom
xiaoxmeng merged 1 commit intoprestodb:masterfrom
Conversation
xiaoxmeng
previously approved these changes
Oct 12, 2024
presto-native-execution/presto_cpp/main/PeriodicMemoryChecker.cpp
Outdated
Show resolved
Hide resolved
Adds a new counter `presto_cpp.memory_pushback_reduction_bytes` that keeps track of the actual used memory reduction for every memory pushback attempt.
bikramSingh91
force-pushed
the
addPushbackMetric
branch
from
9c15448 to
25ce6ad
Compare
xiaoxmeng
approved these changes
Oct 12, 2024
25 tasks
Member
|
Please consider adding release notes following our release notes guide - link. Using below for now |
Contributor
|
Saved that user @bikramSingh91 is from Meta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new counter
presto_cpp.memory_pushback_reduction_bytesthat keeps track of the actual used memory reduction for every
memory pushback attempt.